Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: show context excluded reason in UI #5577

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Chat: show context excluded reason in UI #5577

merged 5 commits into from
Sep 24, 2024

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Sep 13, 2024

CLOSE https://linear.app/sourcegraph/issue/CODY-3725/if-a-user-specifically-mentions-a-file-but-we-dont-use-it-as-context

Right now, users might not be aware of excluded items unless they open the context list, which can cause a lot of confusion when context items were expected:

image

This PR adds a new UI component below the Context item list to display more information about the excluded context to address this issue:

image

Test plan

Updated storybook for the new UI component:

image

After

User can know about the skipped context without opening the context list.

image

Before

User will not know about the skipped context unless they have the context list opened (at the bottom of the list):

image

Changelog

Chat: display a warning in UI when at-mention items were excluded.

@abeatrix abeatrix requested review from chenkc805, a team and vovakulikov September 23, 2024 17:43
@chenkc805
Copy link
Contributor

Thanks Bee!

Can we tweak the copy of the one where user exceeds token limits? Here's what I recommend, assuming we can hyperlink:

  • 2 context items were retrieved but not used because they exceed the token limit. Learn more about token limits here.

Copy link
Contributor

@chenkc805 chenkc805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in my above comment. Thanks @abeatrix

@abeatrix
Copy link
Contributor Author

  • were retrieved but not used because they exceed the token limit. Learn more about token limits

@chenkc805 This looks ok?

image

@chenkc805
Copy link
Contributor

Look great! Approved

@chenkc805 chenkc805 self-requested a review September 24, 2024 18:39
@abeatrix abeatrix merged commit 4be5810 into main Sep 24, 2024
18 checks passed
@abeatrix abeatrix deleted the bee/mention-alert branch September 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants