Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): improve messaging for non-streaming models #5568

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

ykdojo
Copy link
Contributor

@ykdojo ykdojo commented Sep 13, 2024

  • Update the AssistantMessageCell component to provide more informative messaging when a non-streaming model is used
  • The new message explains that non-streaming models may take longer to respond, but are recommended for complex reasoning and coding tasks

This may be slightly too heavy-handed, but I think it's important to show why it takes longer since not everyone will be familiar with the models.

image

Test plan

Test manually.

- Update the `AssistantMessageCell` component to provide more informative messaging when a non-streaming model is used
- The new message explains that non-streaming models may take longer to respond, but are recommended for complex reasoning and coding tasks
@ykdojo ykdojo merged commit 28b5b05 into main Sep 13, 2024
18 of 19 checks passed
@ykdojo ykdojo deleted the fix-o1-messaging branch September 13, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants