fix(commands): remove duplicated commands from Cody Commands menu #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…menu Fixed an issue where duplicated default commands are listed as custom commands in the Cody Commands QuickPick menu. Root cause: All commands (including default ones) were being sent to the quick pick menu during the build step used to append to the menu. Fix: Send only custom commands to the menu, preventing default commands from being listed as custom. - Update showCommandMenu function to use only custom commands - Modify CommandsProvider to pass only custom commands for menu display - Update E2E tests to verify default commands are not shown as custom - Refactor command menu opening functions for consistency - Update CHANGELOG.md to reflect the fix This change ensures that default Cody commands are not incorrectly listed as custom commands in the Cody Commands menu, improving the user experience and reducing confusion.
kalanchan
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-3698/remove-duplicate-command-buttons-in-ui-to-avoid-confusion
This PR fixes an issue where duplicated default commands are listed as custom commands in the Cody Commands QuickPick menu.
Root cause: All commands (including default ones) were being sent to the quick pick menu during the build step used to append to the menu.
Fix: Send only custom commands to the menu, preventing default commands from being listed as custom.
This change ensures that default Cody commands are not incorrectly listed as custom commands in the Cody Commands menu, improving the user experience and reducing confusion.
Test plan
Green CI with the updated E2E test.
Manual Test:
After
Before:
Default commands are showing up twice, once at the top and once at the bottom of the menu:
Changelog