Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the printing of recordings directly to testing/requestErrors #5142

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Aug 8, 2024

The diff information is important to the clients too. Instead of reimplementing it in each client (for the integration test purposes) let's print it directly from the requestErros.

Test plan

@mkondratek mkondratek self-assigned this Aug 8, 2024
@mkondratek mkondratek changed the title suppress ÷ on alt-/ in the chat input (#5116) Move the printing of recordings directly to testing/requestErrors Aug 8, 2024
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather get those diffs as part of the response rather than printout to stdout.
But it's still improvement for JetBrains side.

Please just make sure it does not make experience worse for the agent tests.

Copy link

github-actions bot commented Oct 8, 2024

This PR is marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed automatically in 5 days.

@github-actions github-actions bot added the Stale label Oct 8, 2024
@mkondratek mkondratek closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants