Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use VS Code git extension to get remote URL instead of exec'ing #426

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

sqs
Copy link
Member

@sqs sqs commented Jul 28, 2023

This is more portable (to the web) and compatible (to non-web platforms where git is not installed, not in $PATH, or not configured, which has been the source of many user bug reports).

Test plan

Open a workspace with no cody.codebase setting and ensure the chat sidebar shows the correct repository at the bottom in the context indicator.

This is more portable (to the web) and compatible (to non-web platforms where git is not installed, not in `$PATH`, or not configured, which has been the source of many user bug reports).
@sqs sqs requested a review from a team July 28, 2023 00:49
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Fewer forks.

Is the git extension prevalent enough that we should rely on it, or should we fall back to execing?

@sqs
Copy link
Member Author

sqs commented Jul 28, 2023

@dominiccooney The git extension is a builtin extension, so it's more widely available than git on the $PATH.

@sqs sqs merged commit f094de3 into main Jul 28, 2023
6 checks passed
@sqs sqs deleted the sqs/use-git-ext-remoteurl branch July 28, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants