-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace recipes with commands #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a chance to run it locally, but reviewed as much of the UI copy as I could
vscode/webviews/Recipes.tsx
Outdated
@@ -2,6 +2,8 @@ import { VSCodeButton } from '@vscode/webview-ui-toolkit/react' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest some cleanups to this based on the changes I had in #374, but it's all going to get rm
'd and switched to a quickpick yeah?
Co-authored-by: Tim Lucas <[email protected]> Co-authored-by: Philipp Spiess <[email protected]>
@toolmantim i just pushed some updates so that you won't need to set the feature flag to get those to work. I've also finished with the clean up and updated the PR so it's good to test! Happy to sync up later if you want. |
It took a lot of fighting, but I got it looking pretty good across all themes, including high contrast! I also added a proper focus outline to the input too. command.picker.movA few outstanding things I couldn't fix @beatrix:
|
The main goal of this PR is to deprecate recipes and migrates the popular recipes into commands, a new alternative to
recipes
.See Test Plan on how to enable it for testing.
This PR includes:
my-cody
directory tocustom-prompts
cmd + shift + v
Test plan
added e2e test for custom commands and updated current tests to work with new default commands