Inline Fix: Improve response quality #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
commented
Jul 25, 2023
lib/shared/src/chat/recipes/fixup.ts
Outdated
Comment on lines
90
to
93
| - You will be provided with code that is below the users' selection, enclosed in <belowCode></belowCode> XML tags. You can use this code, if relevant, to help you plan your rewritten code. | ||
| - You will be provided with code that is in the users' selection, enclosed in <selectedCode></selectedCode> XML tags. You must use this code to help you plan your rewritten code. | ||
| - You will be provided with instructions on how to modify this code, enclosed in <instructions></instructions> XML tags. You must follow these instructions carefully and to the letter. | ||
| - Enclose your response in <selection></selection> XML tags. Do not provide anything else. |
There was a problem hiding this comment.
This kind of approach (being very specific by naming the XML tags) is taken from examples in the Anthropic docs. Seems to work well from my testing.
umpox
commented
Jul 26, 2023
lib/shared/src/chat/recipes/fixup.ts
Outdated
| Only provide me with the replacement <selection> and nothing else. | ||
| If it doesn't make sense, you do not need to provide <selection>. Instead, tell me how I can help you to understand my request. | ||
| - You are an AI programming assistant who is an expert in rewriting code to meet given instructions. | ||
| - You should think step-by-step to plan your rewritten code before producing the final output. |
There was a problem hiding this comment.
Seems to work well with Claude, docs
umpox
commented
Jul 31, 2023
Comment on lines
+195
to
+207
| /** | ||
| * The test intent is unique in that we likely want to be much more specific in that context that we retrieve. | ||
| * TODO(umpox): How can infer the current testing dependencies, etc? | ||
| */ | ||
| case 'test': | ||
| // Currently the same as add|edit|fix | ||
| return getContextMessagesFromSelection( | ||
| selection.selectedText, | ||
| truncatedPrecedingText, | ||
| truncatedFollowingText, | ||
| selection, | ||
| context.codebaseContext | ||
| ) |
There was a problem hiding this comment.
@abeatrix Am I correct in that you have been looking at improving the test flows? Interested to see if you've found any specific context gathering to be useful
There was a problem hiding this comment.
Still wip and got pulled into replacing recipes with commands but I did! I'll share what I have first thing tomorrow since I'm afk atm
abeatrix
approved these changes
Aug 1, 2023
| @@ -66,6 +68,26 @@ export function populateCurrentEditorSelectedContextTemplate( | |||
| ) | |||
| } | |||
|
|
|||
| const DIAGNOSTICS_CONTEXT_TEMPLATE = `Use the following {type} from the code snippet in the file \`{filePath}\` | |||
umpox
force-pushed
the
tr/improved-fixup
branch
from
92326b0
to
137b4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the inline
/fixworkflow by:fastmodel to detect intent from the user. Seems to work well from my experience but open to suggestions. I think eventually (once we have a better command UX) we'll want to use this primarily as a fallback and encourage users to use slash commands first.FixupQualityImprovements.mov
Test plan
Lots of manual testing on inline fixups.