-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: fix at symbol title #3531
Conversation
I'd like to leave this message in if there are 2 or more chars after But we can make the message: "No symbols found. Symbols may be loading, or language extensions not installed." (May need overflow ellipsis) |
I think there's a way to check if symbol providers are available in the current workspace or not to display the tooltip more accurately. Let me check on Monday to confirm, and we can add the "(symbols may be loading)" only if that works? @toolmantim |
Oh amazing! That would be even better. |
@toolmantim instead of "No symbols found (symbol maybe be loading)", what do you think about "Searching symbols..." and then display "No symbols found" after a timeout? |
I thought the API immediately returns a nil result? But if that's not right, or you're thinking of polling/retrying… some kind of experience like that could be nice. How would you calculate the timeout though, because huge codebases could take a very long time, and I'd still want us to show "(language extensions may be loading)" |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3530
A user on Discord has reported that Cody is incorrectly showing an error message "No symbols found (try installing language extensions and opening a file)":
This error message/tooltip is incorrect as the result is expected to be empty when the query is empty, and not required to have a file opened for symbol search, this PR reverts the tooltip back to
'Search for a symbol to include...'
to display on start-up screen.Test plan
@#
in the input, you should see'Search for a symbol to include...'
No symbols found
is displayed when no result is returned after typing more than 1 character