Chat: Disable adding large-file via @-mention #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
toolmantim
reviewed
Mar 25, 2024
vscode/webviews/promptEditor/plugins/atMentions/OptionsList.module.css
Outdated
Show resolved
Hide resolved
philipp-spiess
approved these changes
Mar 25, 2024
…dule.css Co-authored-by: Tim Lucas <[email protected]>
|
This is a great addition, but now the user cannot even use line ranges to narrow the context of the 'too large file'. Thank you |
Please consider this. Line ranges is indeed the feature I use the most to manually gather best context to feed to the model. |
|
@PriNova @hlhdaiaaii Thanks for raising that issue with us! I've filed an issue for tracking purpose, and will look into supporting range for large files again! #3589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE #3522
A new check has been added to the contextItemMentionNodeDisplayText function. If the contextItem is of type 'file' and has the isTooLarge flag set to true, the context item cannot be added as an @-mention token.
In the Item component, a new warning prop has been added to conditionally apply the .disabled class to the option item. This is used to visually indicate that a large file is disabled and cannot be selected from the context list:
Test plan
Try to @ a large file
You should not be able to add the file