-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: speed up builds w/ parallelism #3444
Conversation
fedc4f1
to
382b0a4
Compare
This might be because the global `loggedEvents` is written to by several parallel tests at once. I'm not sure. I would have thought that each test case would be run in a separate process, but that does not necessarily seem to be the case.
@toolmantim I made a bit more progress here. See #3449 in case it's helpful. |
ba040a3
to
05cc633
Compare
762c854
to
dddc414
Compare
@toolmantim ooh nice fix for telemetry. Is this working for |
Yeah, but not reliably without retries:
I doubt we'll get this stable… I think it's best we just shard and bump instances sizes instead. It's also very easy to scale shards. |
Actually, after some more battle testing I am getting local flakiness with 1 worker too. I'll cherry-pick f85a049 and run things again. |
Build time is now 13 min. Last time (pre-windows builds) we got it back down to 4-5 min by bumping macOS instance size. We've hit the limits for bumping instance on macOS, so we'll need to split tasks (and probably bump instances for Windows & Ubuntu, which require GitHub org admin access).
But first let's see if we can parallelize on-machine, though I'm not hopeful: in general I've found this to be a fool's errand — parallelising e2e tests is a notorious change for introducing flakiness.
Test plan
n/a