-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in the transcript context list, omit needless '@' prefix #3439
Conversation
@toolmantim can you design-check this? |
1e31830
to
b69baec
Compare
ab824df
to
eb8f45c
Compare
b69baec
to
7ac8e2c
Compare
a0f2ddd
to
004ecb5
Compare
I don’t have a Figma for it, but I think better than removing would be to use different icons to show where/why the file/lines were included. The more we can show where/why the better. Codicon has a proper @ icon we could use for explicitly @‘d things. File lines included from a selection could use another icon. And things included from enhanced context could use the same DB icon as sources from the enhanced context popover. With tooltips for each one, e.g. “Included from @-mentions” or “Included from the search index via Enhanced Context”. wdyt? I’m happy for you to rough it out and I jump in to CSS it, or can Figma it if it’s not clear. |
@toolmantim That sounds great. I'm not sure that icons for /why/ make the most sense, though. We will soon have multiple types of context (already do: files, symbols, terminal) and the icon should probably be what the thing is, not why it was included. (How) should we represent both? |
ddc78c0
to
74eebdc
Compare
@sqs here's two design ideas:
2 rethinks how we display chips now we have a rich editor (I imagine we could add some hover cards to chips too) |
When you click to open the `Context: 123 lines from 456 files` list, now the items no longer are prefixed with `@`. For example, it will show `my/file.ts:12-34` rather than `@my/file.ts:12-34`. The `@` is not needed when displaying the list here.
74eebdc
to
cdba0f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you click to open the
Context: 123 lines from 456 files
list, now the items no longer are prefixed with@
. For example, it will showmy/file.ts:12-34
rather than@my/file.ts:12-34
. The@
is not needed when displaying the list here.Test plan
CI