Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize on a single prompt format for codebase context #3412

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented Mar 14, 2024

Previously, there were several very similar (but slightly different) templates for introducing code snippets as context.

  • "Use the following text from FILE ..."
  • Sometimes backticks around file paths and repo names, sometimes not.
  • Markdown files are cited differently from non-Markdown files.

There were also several unused functions here.

This improves the response quality regarding #3331 (for the how does authentication work in sourcegraph/cody? question at least).

Test plan

CI

@sqs sqs requested a review from a team March 14, 2024 19:27
Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think these subtle differences are accidental and don't have clear motivation. (Caveat: I'm far from a Cody Clients expert!)

Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! From what I've tested "codebase context from..." works the best for chat. Thanks for cleaning this up!

Previously, there were several very similar (but slightly different) templates for introducing code snippets as context.

- "Use the following text from FILE ..."
- Sometimes backticks around file paths and repo names, sometimes not.
- Markdown files are cited differently from non-Markdown files.

There were also several unused functions here.

This improves the response quality regarding #3331.
@sqs sqs enabled auto-merge (squash) March 15, 2024 01:39
@sqs sqs merged commit 6fac7d0 into main Mar 15, 2024
16 checks passed
@sqs sqs deleted the sqs/question-prompt branch March 15, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants