Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump dependencies #3387

Merged
merged 6 commits into from
Mar 26, 2024
Merged

chore: Bump dependencies #3387

merged 6 commits into from
Mar 26, 2024

Conversation

evict
Copy link
Contributor

@evict evict commented Mar 12, 2024

This updates most medium and all high & critical risk rated vulnerabilities in dependencies. These were reported by Dependabot.

Test plan

CI tests

@evict evict requested review from willdollman, abeatrix and a team March 12, 2024 17:03
sqs
sqs previously requested changes Mar 13, 2024
Copy link
Member

@sqs sqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evict What did you run to add these? Was it manual? I see new deps added to devDependencies that we don't directly use. If the purpose of that was to pin transitive deps to a specific version, we should use package.json's resolutions property instead. Otherwise, the pinned but not-directly-used deps will be removed next time we run something like Knip to remove unused code and deps, and we could fall back to the unsafe dep versions.

@evict evict force-pushed the security/bump-dependencies branch 3 times, most recently from 134478e to 6b47610 Compare March 13, 2024 11:23
@evict
Copy link
Contributor Author

evict commented Mar 13, 2024

@evict What did you run to add these? Was it manual? I see new deps added to devDependencies that we don't directly use. If the purpose of that was to pin transitive deps to a specific version, we should use package.json's resolutions property instead. Otherwise, the pinned but not-directly-used deps will be removed next time we run something like Knip to remove unused code and deps, and we could fall back to the unsafe dep versions.

TIL, thank you! We updated it as dependabot recommended, which was indeed manual.

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the inline snapshot formatter from vitest has gotten an update in one of the version bumps here. Should be fine to run pnpm test -u to update these.

My only recommendation is to try upgrading everything to latest versions instead of focusing only on the vulnerable sub-dependenceis to avoid having to use resolutions too much since it might make upgrading later feel more tedious. However if there's a lot of breaking changes, this should work too. Let's just be mindful about the change.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@evict evict force-pushed the security/bump-dependencies branch from e49ef1a to fa1e867 Compare March 13, 2024 15:02
@evict evict force-pushed the security/bump-dependencies branch from 4db55af to 652596a Compare March 25, 2024 12:49
@evict evict requested a review from a team March 25, 2024 12:50
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Let's see if we get CI to pass :D

@philipp-spiess philipp-spiess dismissed sqs’s stale review March 26, 2024 16:33

feedback was adressed

@evict evict force-pushed the security/bump-dependencies branch from 985fac6 to a92bd46 Compare March 26, 2024 17:13
@evict evict merged commit 45caa2f into main Mar 26, 2024
20 checks passed
@evict evict deleted the security/bump-dependencies branch March 26, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants