-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump dependencies #3387
chore: Bump dependencies #3387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evict What did you run to add these? Was it manual? I see new deps added to devDependencies
that we don't directly use. If the purpose of that was to pin transitive deps to a specific version, we should use package.json's resolutions
property instead. Otherwise, the pinned but not-directly-used deps will be removed next time we run something like Knip to remove unused code and deps, and we could fall back to the unsafe dep versions.
134478e
to
6b47610
Compare
TIL, thank you! We updated it as dependabot recommended, which was indeed manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the inline snapshot formatter from vitest has gotten an update in one of the version bumps here. Should be fine to run pnpm test -u
to update these.
My only recommendation is to try upgrading everything to latest versions instead of focusing only on the vulnerable sub-dependenceis to avoid having to use resolutions
too much since it might make upgrading later feel more tedious. However if there's a lot of breaking changes, this should work too. Let's just be mindful about the change.
e49ef1a
to
fa1e867
Compare
4db55af
to
652596a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Let's see if we get CI to pass :D
985fac6
to
a92bd46
Compare
This updates most medium and all high & critical risk rated vulnerabilities in dependencies. These were reported by Dependabot.
Test plan
CI tests