Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Add configuration for Ollama chat server #3358

Closed
wants to merge 6 commits into from

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Mar 8, 2024

Follow up on #3282, #3282 (comment) in specific, to make the URL for the chat completion endpoint to be configurable. Default to use the default Ollama local host.

  • Add experimentalOllamaChatApiEndpoint to Configuration interface
  • Update ollamaChatClient to use configurable API endpoint
  • Add apiEndpoint to CompletionParameters interface
  • Add cody.experimental.ollamaChat.ApiEndpoint setting to VSCode extension
  • Pass configured API endpoint to chatClient.chat in SimpleChatPanelProvider

This allows using a custom API endpoint for the Ollama chat models, enabling cases where the chat server is hosted remotely, or separately from their autocompletion server

Test plan

Update the new configuration to see if the chat works based on the change

@abeatrix abeatrix requested review from dominiccooney, philipp-spiess, valerybugakov and a team and removed request for dominiccooney March 8, 2024 14:30
@abeatrix abeatrix marked this pull request as draft March 8, 2024 20:31
@abeatrix abeatrix marked this pull request as ready for review March 18, 2024 15:30
@abeatrix abeatrix marked this pull request as draft March 26, 2024 02:28
Copy link

github-actions bot commented Jun 2, 2024

This PR is marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed automatically in 5 days.

@github-actions github-actions bot added the Stale label Jun 2, 2024
@github-actions github-actions bot closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant