Cody: Hide feedback button on err response (#448)

This PR closes #112.

## Test plan


https://github.com/sourcegraph/cody/assets/44617923/9afef662-9085-4ee8-b0db-4f153a207cb8

lib/ui/src/Chat.tsx

@@ -47,6 +47,7 @@ interface ChatProps extends ChatClassNames {
     isCodyEnabled: boolean
     ChatButtonComponent?: React.FunctionComponent<ChatButtonProps>
     pluginsDevMode?: boolean
+    isTranscriptError?: boolean
 }
 
 interface ChatClassNames extends TranscriptItemClassNames {
@@ -148,6 +149,7 @@ export const Chat: React.FunctionComponent<ChatProps> = ({
     isCodyEnabled,
     ChatButtonComponent,
     pluginsDevMode,
+    isTranscriptError,
 }) => {
     const [inputRows, setInputRows] = useState(1)
     const [historyIndex, setHistoryIndex] = useState(inputHistory.length)
@@ -284,6 +286,7 @@ export const Chat: React.FunctionComponent<ChatProps> = ({
                     chatInputClassName={chatInputClassName}
                     ChatButtonComponent={ChatButtonComponent}
                     pluginsDevMode={pluginsDevMode}
+                    isTranscriptError={isTranscriptError}
                 />
             )}
 

lib/ui/src/chat/Transcript.tsx

@@ -35,6 +35,7 @@ export const Transcript: React.FunctionComponent<
         submitButtonComponent?: React.FunctionComponent<ChatUISubmitButtonProps>
         ChatButtonComponent?: React.FunctionComponent<ChatButtonProps>
         pluginsDevMode?: boolean
+        isTranscriptError?: boolean
     } & TranscriptItemClassNames
 > = React.memo(function TranscriptContent({
     transcript,
@@ -59,6 +60,7 @@ export const Transcript: React.FunctionComponent<
     chatInputClassName,
     ChatButtonComponent,
     pluginsDevMode,
+    isTranscriptError,
 }) {
     const transcriptContainerRef = useRef<HTMLDivElement>(null)
     useEffect(() => {
@@ -118,7 +120,7 @@ export const Transcript: React.FunctionComponent<
                             FeedbackButtonsContainer={FeedbackButtonsContainer}
                             feedbackButtonsOnSubmit={feedbackButtonsOnSubmit}
                             copyButtonOnSubmit={copyButtonOnSubmit}
-                            showFeedbackButtons={index !== 0}
+                            showFeedbackButtons={index !== 0 && !isTranscriptError}
                             submitButtonComponent={submitButtonComponent}
                             chatInputClassName={chatInputClassName}
                             ChatButtonComponent={ChatButtonComponent}

vscode/CHANGELOG.md

@@ -43,6 +43,7 @@ Starting from `0.2.0`, Cody is using `major.EVEN_NUMBER.patch` for release versi
 ### Changed
 
 - Removed the experimental hallucination detection that highlighted nonexistent file paths.
+- Hide the feedback button in case of error assistant response. [pull/448](https://github.com/sourcegraph/cody/pull/448)
 
 ## [0.6.2]
 

vscode/src/chat/ChatViewProvider.ts

@@ -166,6 +166,13 @@ export class ChatViewProvider extends MessageProvider implements vscode.WebviewV
         })
     }
 
+    /**
+     * Send transcript error to webview
+     */
+    protected handleTranscriptErrors(transcriptError: boolean): void {
+        void this.webview?.postMessage({ type: 'transcript-errors', isTranscriptError: transcriptError })
+    }
+
     protected handleSuggestions(suggestions: string[]): void {
         void this.webview?.postMessage({
             type: 'suggestions',

vscode/src/chat/InlineChatViewProvider.ts

@@ -120,4 +120,8 @@ export class InlineChatViewProvider extends MessageProvider {
     protected handleMyPrompts(): void {
         // my prompts not yet implemented for inline chat
     }
+
+    protected handleTranscriptErrors(): void {
+        // handle transcript errors not yet implemented for inline chat
+    }
 }

vscode/src/chat/MessageProvider.ts

@@ -53,6 +53,7 @@ abstract class MessageHandler {
     protected abstract handleSuggestions(suggestions: string[]): void
     protected abstract handleEnabledPlugins(plugins: string[]): void
     protected abstract handleMyPrompts(prompts: string[], isEnabled: boolean): void
+    protected abstract handleTranscriptErrors(transciptError: boolean): void
 }
 
 export interface MessageProviderOptions {
@@ -271,6 +272,7 @@ export abstract class MessageProvider extends MessageHandler implements vscode.D
                 }
                 // Display error message as assistant response
                 this.transcript.addErrorAsAssistantResponse(err)
+                this.handleTranscriptErrors(true)
                 // We ignore embeddings errors in this instance because we're already showing an
                 // error message and don't want to overwhelm the user.
                 void this.onCompletionEnd(true)
@@ -653,6 +655,7 @@ export abstract class MessageProvider extends MessageHandler implements vscode.D
         // Display error message as assistant response for users with indexed codebase but getting search errors
         if (this.contextProvider.context.checkEmbeddingsConnection() && searchErrors) {
             this.transcript.addErrorAsAssistantResponse(searchErrors)
+            this.handleTranscriptErrors(true)
             debug('ChatViewProvider:onLogEmbeddingsErrors', '', { verbose: searchErrors })
         }
     }

vscode/src/chat/protocol.ts

@@ -51,6 +51,7 @@ export type ExtensionMessage =
     | { type: 'app-state'; isInstalled: boolean }
     | { type: 'enabled-plugins'; plugins: string[] }
     | { type: 'my-prompts'; prompts: string[]; isEnabled: boolean }
+    | { type: 'transcript-errors'; isTranscriptError: boolean }
 
 /**
  * The subset of configuration that is visible to the webview.

vscode/webviews/App.tsx

@@ -40,6 +40,7 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
     const [isAppInstalled, setIsAppInstalled] = useState<boolean>(false)
     const [enabledPlugins, setEnabledPlugins] = useState<string[]>([])
     const [myPrompts, setMyPrompts] = useState<string[] | null>(null)
+    const [isTranscriptError, setIsTranscriptError] = useState<boolean>(false)
 
     useEffect(
         () =>
@@ -50,6 +51,7 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
                             const msgLength = message.messages.length - 1
                             setTranscript(message.messages.slice(0, msgLength))
                             setMessageInProgress(message.messages[msgLength])
+                            setIsTranscriptError(false)
                         } else {
                             setTranscript(message.messages)
                             setMessageInProgress(null)
@@ -90,6 +92,9 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
                     case 'my-prompts':
                         setMyPrompts(message.isEnabled ? message.prompts : null)
                         break
+                    case 'transcript-errors':
+                        setIsTranscriptError(message.isTranscriptError)
+                        break
                 }
             }),
         [errorMessages, view, vscodeAPI]
@@ -177,6 +182,7 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
                             pluginsDevMode={Boolean(config?.pluginsDebugEnabled)}
                             setSuggestions={setSuggestions}
                             telemetryService={telemetryService}
+                            isTranscriptError={isTranscriptError}
                             showOnboardingButtons={userHistory && Object.entries(userHistory).length === 0}
                         />
                     )}

vscode/webviews/Chat.tsx

@@ -39,6 +39,7 @@ interface ChatboxProps {
     suggestions?: string[]
     setSuggestions?: (suggestions: undefined | string[]) => void
     pluginsDevMode?: boolean
+    isTranscriptError: boolean
     showOnboardingButtons?: boolean | null
 }
 
@@ -57,6 +58,7 @@ export const Chat: React.FunctionComponent<React.PropsWithChildren<ChatboxProps>
     suggestions,
     setSuggestions,
     pluginsDevMode,
+    isTranscriptError,
     showOnboardingButtons,
 }) => {
     const [abortMessageInProgressInternal, setAbortMessageInProgress] = useState<() => void>(() => () => undefined)
@@ -149,6 +151,7 @@ export const Chat: React.FunctionComponent<React.PropsWithChildren<ChatboxProps>
             setSuggestions={setSuggestions}
             abortMessageInProgressComponent={AbortMessageInProgress}
             onAbortMessageInProgress={abortMessageInProgress}
+            isTranscriptError={isTranscriptError}
             // TODO: We should fetch this from the server and pass a pretty component
             // down here to render cody is disabled on the instance nicely.
             isCodyEnabled={true}