Chat: show enhanced context settings on first chat (#3567)

sourcegraph · Mar 27, 2024 · a88b9cf · a88b9cf
1 parent ff459b6
commit a88b9cf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/vscode/webviews/App.tsx b/vscode/webviews/App.tsx
@@ -191,7 +191,7 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
     )
 
     const telemetryService = useMemo(() => createWebviewTelemetryService(vscodeAPI), [vscodeAPI])
-
+    const isNewInstall = useMemo(() => !userHistory.some(c => c.interactions.length > 0), [userHistory])
     if (!view || !authStatus || !config) {
         return <LoadingPage />
     }
@@ -207,12 +207,7 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
                 />
             ) : (
                 <>
-                    <Notices
-                        probablyNewInstall={
-                            !userHistory.filter(chat => chat.interactions.length)?.length
-                        }
-                        vscodeAPI={vscodeAPI}
-                    />
+                    <Notices probablyNewInstall={isNewInstall} vscodeAPI={vscodeAPI} />
                     {errorMessages && (
                         <ErrorBanner errors={errorMessages} setErrors={setErrorMessages} />
                     )}
@@ -246,6 +241,7 @@ export const App: React.FunctionComponent<{ vscodeAPI: VSCodeWrapper }> = ({ vsc
                                         guardrails={attributionEnabled ? guardrails : undefined}
                                         chatIDHistory={chatIDHistory}
                                         isWebviewActive={isWebviewActive}
+                                        isNewInstall={isNewInstall}
                                     />
                                 </EnhancedContextEnabled.Provider>
                             </EnhancedContextContext.Provider>

diff --git a/vscode/webviews/Chat.story.tsx b/vscode/webviews/Chat.story.tsx
@@ -28,6 +28,7 @@ const meta: Meta<typeof Chat> = {
         },
         telemetryService: null as any,
         isTranscriptError: false,
+        isNewInstall: false,
     } satisfies React.ComponentProps<typeof Chat>,
 
     decorators: [WithBorder, VSCodeStoryDecorator],

diff --git a/vscode/webviews/Chat.tsx b/vscode/webviews/Chat.tsx
@@ -45,6 +45,7 @@ interface ChatboxProps {
     guardrails?: Guardrails
     chatIDHistory: string[]
     isWebviewActive: boolean
+    isNewInstall: boolean
 }
 
 const isMac = isMacOS()
@@ -63,6 +64,7 @@ export const Chat: React.FunctionComponent<React.PropsWithChildren<ChatboxProps>
     guardrails,
     chatIDHistory,
     isWebviewActive,
+    isNewInstall,
 }) => {
     const [messageBeingEdited, setMessageBeingEdited] = useState<number | undefined>(undefined)
 
@@ -530,7 +532,7 @@ export const Chat: React.FunctionComponent<React.PropsWithChildren<ChatboxProps>
                                 isOpen={isEnhancedContextOpen}
                                 setOpen={onEnhancedContextTogglerClick}
                                 presentationMode={userInfo.isDotComUser ? 'consumer' : 'enterprise'}
-                                isFirstChat={transcript.length < 1}
+                                isFirstChat={isNewInstall}
                             />
                         </div>
                     </div>

diff --git a/vscode/webviews/Components/EnhancedContextSettings.tsx b/vscode/webviews/Components/EnhancedContextSettings.tsx
@@ -390,9 +390,7 @@ export const EnhancedContextSettings: React.FunctionComponent<EnhancedContextSet
     }, [isOpen])
 
     React.useEffect(() => {
-        if (isFirstChat) {
-            setOpen(true)
-        }
+        setOpen(isFirstChat)
     }, [isFirstChat, setOpen])
 
     // Can't point at and use VSCodeButton type with 'ref'