Fix configuration inspect method

sourcegraph · Nov 6, 2024 · 44e992b · 44e992b
1 parent 836693e
commit 44e992b
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/agent/src/AgentWorkspaceConfiguration.test.ts b/agent/src/AgentWorkspaceConfiguration.test.ts
@@ -205,8 +205,26 @@ describe('AgentWorkspaceConfiguration', () => {
     })
 
     describe('inspect', () => {
-        it('returns undefined for any section', () => {
-            expect(config.inspect('cody.serverEndpoint')).toBeUndefined()
+        it('returns correct values for existing section', () => {
+            expect(config.inspect('cody.serverEndpoint')).toStrictEqual({
+                defaultValue: undefined,
+                globalValue: 'https://sourcegraph.test',
+                key: 'cody.serverEndpoint',
+                workspaceValue: 'https://sourcegraph.test',
+            })
+        })
+
+        it('returns correct default values for pre-defined properties', () => {
+            expect(config.inspect('cody.commandCodeLenses')).toStrictEqual({
+                defaultValue: false,
+                globalValue: false,
+                key: 'cody.commandCodeLenses',
+                workspaceValue: false,
+            })
+        })
+
+        it('returns undefined for not defined properties', () => {
+            expect(config.inspect('some.undefined.value')).toStrictEqual(undefined)
         })
     })
 

diff --git a/agent/src/AgentWorkspaceConfiguration.ts b/agent/src/AgentWorkspaceConfiguration.ts
@@ -165,7 +165,16 @@ export class AgentWorkspaceConfiguration implements vscode.WorkspaceConfiguratio
               languageIds?: string[] | undefined
           }
         | undefined {
-        return undefined
+        const value = this.get(section)
+        if (value === undefined) {
+            return undefined
+        }
+        return {
+            key: section,
+            defaultValue: defaultConfigurationValue(section),
+            globalValue: value,
+            workspaceValue: value,
+        }
     }
 
     public async update(