Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication-service): added idp server controller for login and discovery endpoint #2131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

prernagp
Copy link
Contributor

@prernagp prernagp commented Jul 10, 2024

Description

Added IDP server controller for login and discovery endpoint

Fixes # (issue) #2034

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • Code conforms with the style guide
  • API Documentation in code was updated

@prernagp prernagp requested review from Surbhi-sharma1 and a team as code owners July 10, 2024 06:27
Copy link

@sfvishalgupta sfvishalgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not see all the endpoints mentioned here, https://docs.google.com/document/d/1r2v55eC5dbGBsA5ka_JQnzIIO80hdTqA6p8qCRKQmqU/edit
Also please specify and work on key rotation

@prernagp prernagp force-pushed the issue-2034 branch 4 times, most recently from 8aafdb7 to b5303d9 Compare July 23, 2024 10:23
@@ -25,6 +25,7 @@
}
},
"scripts": {
"start": "node -r source-map-support/register .",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this ?

})
req: RefreshTokenRequest,
): Promise<SuccessResponse> {
const token = auth?.replace(/bearer /i, '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant we reuse existing code ?

@prernagp prernagp force-pushed the issue-2034 branch 2 times, most recently from c66c5ac to f1ed738 Compare September 10, 2024 10:16
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9 New issues
9 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@prernagp prernagp force-pushed the issue-2034 branch 3 times, most recently from ffcf860 to ff1489e Compare November 8, 2024 09:12
MIGRATION CHANGE:
migration-20241105074844-

BREAKING CHANGE:
JWT Asymmetric Signer and Verifier will be served from Database only. File support has been removed.

2034
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10 New issues
9 New Blocker Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants