cc-5709: Airtime Analyzer #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| track_number = audio_file["tracknumber"] | ||
| if isinstance(track_number, list): # Sometimes tracknumber is a list, ugh | ||
| track_number = track_number[0] |
There was a problem hiding this comment.
wondering what else is in this list if anything?
…rtime into cc-5709-airtime-analyzer
Execute raw sql upgrade file at the end in case errors occured during the upgrade before it gets executed
…rtime into cc-5709-airtime-analyzer
Changed where we insert new application.ini file lines
…rtime into cc-5709-airtime-analyzer
…ort process to throw out bad track number metadata
Added file size and hash to the metadata dict in the analyzer
…rtime into cc-5709-airtime-analyzer
* SAAS-376 and CC-5868
Removed try/except while getting file size and hash
Renamed metadata md5 value to match cc_files column
…rtime-analyzer Conflicts: airtime_mvc/application/models/airtime/CcFiles.php airtime_mvc/application/modules/rest/controllers/MediaController.php
…rtime into cc-5709-airtime-analyzer
* Also cleaned up pull request
…-store-file-size-and-hash-in-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting airtime_analyzer and all the PHP changes up for review. We might only end up merging this code into 2.6.x, but it'll be easier to review it as a diff against 2.5.x for now.