Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrabble: include all words #252

Merged
merged 3 commits into from
Oct 8, 2023
Merged

scrabble: include all words #252

merged 3 commits into from
Oct 8, 2023

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Oct 8, 2023

updating the scrabble module to contain an array of all scrabble words. Previously only words of size 10 and up were included. Removed list of words for performance. So we only include an array of words: will be useful for a binary search assessment.

@martin-henz martin-henz changed the title All words scrabble: include all words Oct 8, 2023
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with just one minor comment:

function list_ref(list, n) {
return n === 0 ? list[0] : list_ref(list[1], n - 1);
}
import { scrabble_words } from '../functions';

// Test functions

test('get the first word in the array', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can change the test description

@martin-henz martin-henz merged commit ddb1767 into master Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants