Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert runtime-error regression in zero duration #250

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

kjw142857
Copy link
Contributor

@kjw142857 kjw142857 commented Oct 1, 2023

Description

Revert regression that caused make_sound to reject durations of length 0, which affected the consecutively and simultaneously functions

Note: Issue was caused by #234

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Revert regression that caused make_sound to reject durations of length 0, which affected the consecutively and simultaneously functions
@RichDom2185 RichDom2185 enabled auto-merge (squash) October 1, 2023 09:31
@RichDom2185
Copy link
Member

Fixes the regression introduced in #234.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit baed5a1 into source-academy:master Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants