Update iOS project version and add recreation activities menu item #84
Conversation
|
I take it TestFlight build 16 came from this branch? |
|
@steinbro yes. I'm going to change this to draft because it is not ready to merge. |
|
I'll rebase this once the issue with #73 is resolved. |
bumped build number to 19
|
I found the issue in #73 and pushed it to main. This branch has been rebased. |
|
This is included in build 19 on testflight. the new geojson code is not on testflight yet. |
| @@ -15,6 +15,7 @@ final class AuthoredActivityContentTest: XCTestCase { | |||
|
|
|||
| // MARK: Test GPX Parsing | |||
|
|
|||
| static let baseURL = URL(string: "https://example.com")! | |||
There was a problem hiding this comment.
I'm guessing this is extraneous, though probably harmless.
| default: | ||
| // no other versions currently supported | ||
| break |
There was a problem hiding this comment.
I'm curious why there wasn't a default case before. I'm not sure what Swift semantics are for unhandled cases, but the behavior with the default case (return an empty URL) seems correct.
There was a problem hiding this comment.
I think all cases were handled explicitly before. Swift does require all cases to be handled either explicitly or with a default case.
I was thinking of proposing a v4 link in the future that would contain the full URL to the activity.gpx file. That would allow the authoring tool to be used on other domains for development etc.
This is hopefully a start to getting the app working with recreational activities again. currently build 15 on testflight but doesn't work yet.