Add time_stamp and limit table name to 64 characters

lib/lhm/table.rb

@@ -7,12 +7,13 @@ module Lhm
  class Table
  attr_reader :name, :columns, :indices, :pk, :ddl
 
- def initialize(name, pk = 'id', ddl = nil)
+ def initialize(name, pk = 'id', ddl = nil, time = Time.now)
  @name = name
  @columns = {}
  @indices = {}
  @pk = pk
  @ddl = ddl
+ @time = time
  end
 
  def satisfies_id_column_requirement?
@@ -21,7 +22,11 @@ def satisfies_id_column_requirement?
  end
 
  def destination_name
- "lhmn_#{ @name }"
+ "lhmn_#{ time_stamp }_#{ @name }"[0...64]
+ end
+
+ def time_stamp
+ @time.strftime "%Y_%m_%d_%H_%M_%S_#{ '%03d' % (@time.usec / 1000) }"
  end
 
  def self.parse(table_name, connection)

spec/unit/migrator_spec.rb

@@ -10,7 +10,9 @@
  include UnitHelper
 
  before(:each) do
- @table = Lhm::Table.new('alt')
+ @time = Time.now
+ @stamp = "%Y_%m_%d_%H_%M_%S_#{ '%03d' % (@time.usec / 1000) }"
+ @table = Lhm::Table.new('alt', 'id', nil, @time)
  @creator = Lhm::Migrator.new(@table)
  end
 
@@ -19,31 +21,31 @@
  @creator.add_index(:a)
 
  @creator.statements.must_equal([
- 'create index `index_alt_on_a` on `lhmn_alt` (`a`)'
+ "create index `index_alt_on_a` on `lhmn_#{ @time.strftime(@stamp) }_alt` (`a`)"
  ])
  end
 
  it 'should add a composite index' do
  @creator.add_index([:a, :b])
 
  @creator.statements.must_equal([
- 'create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`, `b`)'
+ "create index `index_alt_on_a_and_b` on `lhmn_#{ @time.strftime(@stamp) }_alt` (`a`, `b`)"
  ])
  end
 
  it 'should add an index with prefix length' do
  @creator.add_index(['a(10)', 'b'])
 
  @creator.statements.must_equal([
- 'create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(10), `b`)'
+ "create index `index_alt_on_a_and_b` on `lhmn_#{ @time.strftime(@stamp) }_alt` (`a`(10), `b`)"
  ])
  end
 
  it 'should add an index with a custom name' do
  @creator.add_index([:a, :b], :custom_index_name)
 
  @creator.statements.must_equal([
- 'create index `custom_index_name` on `lhmn_alt` (`a`, `b`)'
+ "create index `custom_index_name` on `lhmn_#{ @time.strftime(@stamp) }_alt` (`a`, `b`)"
  ])
  end
 
@@ -57,15 +59,15 @@
  @creator.add_unique_index(['a(5)', :b])
 
  @creator.statements.must_equal([
- 'create unique index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(5), `b`)'
+ "create unique index `index_alt_on_a_and_b` on `lhmn_#{ @time.strftime(@stamp) }_alt` (`a`(5), `b`)"
  ])
  end
 
  it 'should add a unique index with a custom name' do
  @creator.add_unique_index([:a, :b], :custom_index_name)
 
  @creator.statements.must_equal([
- 'create unique index `custom_index_name` on `lhmn_alt` (`a`, `b`)'
+ "create unique index `custom_index_name` on `lhmn_#{ @time.strftime(@stamp) }_alt` (`a`, `b`)"
  ])
  end
 
@@ -79,15 +81,15 @@
  @creator.remove_index(['b', 'a'])
 
  @creator.statements.must_equal([
- 'drop index `index_alt_on_b_and_a` on `lhmn_alt`'
+ "drop index `index_alt_on_b_and_a` on `lhmn_#{ @time.strftime(@stamp) }_alt`"
  ])
  end
 
  it 'should remove an index with a custom name' do
  @creator.remove_index([:a, :b], :custom_index_name)
 
  @creator.statements.must_equal([
- 'drop index `custom_index_name` on `lhmn_alt`'
+ "drop index `custom_index_name` on `lhmn_#{ @time.strftime(@stamp) }_alt`"
  ])
  end
  end
@@ -97,23 +99,23 @@
  @creator.add_column('logins', 'INT(12)')
 
  @creator.statements.must_equal([
- 'alter table `lhmn_alt` add column `logins` INT(12)'
+ "alter table `lhmn_#{ @time.strftime(@stamp) }_alt` add column `logins` INT(12)"
  ])
  end
 
  it 'should remove a column' do
  @creator.remove_column('logins')
 
  @creator.statements.must_equal([
- 'alter table `lhmn_alt` drop `logins`'
+ "alter table `lhmn_#{ @time.strftime(@stamp) }_alt` drop `logins`"
  ])
  end
 
  it 'should change a column' do
  @creator.change_column('logins', 'INT(11)')
 
  @creator.statements.must_equal([
- 'alter table `lhmn_alt` modify column `logins` INT(11)'
+ "alter table `lhmn_#{ @time.strftime(@stamp) }_alt` modify column `logins` INT(11)"
  ])
  end
  end
@@ -123,7 +125,7 @@
  @creator.ddl('alter table `%s` add column `f` tinyint(1)' % @creator.name)
 
  @creator.statements.must_equal([
- 'alter table `lhmn_alt` add column `f` tinyint(1)'
+ "alter table `lhmn_#{ @time.strftime(@stamp) }_alt` add column `f` tinyint(1)"
  ])
  end
  end
@@ -136,11 +138,11 @@
 
  @creator.
  statements[0].
- must_equal('alter table `lhmn_alt` add column `first` VARCHAR(64)')
+ must_equal("alter table `lhmn_#{ @time.strftime(@stamp) }_alt` add column `first` VARCHAR(64)")
 
  @creator.
  statements[1].
- must_equal('alter table `lhmn_alt` add column `last` VARCHAR(64)')
+ must_equal("alter table `lhmn_#{ @time.strftime(@stamp) }_alt` add column `last` VARCHAR(64)")
  end
  end
 end

spec/unit/table_spec.rb

@@ -10,8 +10,10 @@
 
  describe 'names' do
  it 'should name destination' do
- @table = Lhm::Table.new('users')
- @table.destination_name.must_equal 'lhmn_users'
+ @time = Time.now
+ @table = Lhm::Table.new('users', 'id', nil, @time)
+ stamp = "%Y_%m_%d_%H_%M_%S_#{ '%03d' % (@time.usec / 1000) }"
+ @table.destination_name.must_equal "lhmn_#{ @time.strftime(stamp) }_users"
  end
  end