WIP ported code to webpack 4 #56
Open
+90
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #55 |
brudil
reviewed
Apr 18, 2018
|
|
||
| return source.replace( | ||
| `"${chunkManifestFilename}"`, | ||
| `window['${this.options.manifestVariable}']['${chunkId}']`, |
There was a problem hiding this comment.
Should chunkId be quoted here? I had to unquote it because I think it's referring to the name variable in scope. (I've never done Webpack hooks stuff, so I might be completely wrong here)
There was a problem hiding this comment.
yup, my bad.
edit: actually it looks like it's quoted on L 56 in the master so probably should be as is.
|
@brudil can we please merge this so I can use this plugin with webpack 4? |
|
@bf I'm nothing to do with this repo, just a user of the plugin itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i went through this today for my team, but we don't use all the options so i'm not sure how to fully test without a suite. maybe an okay starting point?