feat: 팝업스토어 및 태그 구현 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangAJang
reviewed
Aug 13, 2024
| public Popups toDomain(final Long memberId) { | ||
| return Popups.builder() | ||
| .ownerId(memberId) | ||
| .storeDetails(StoreDetails.builder() |
There was a problem hiding this comment.
builder하나에 두기에는 분리하는게 어떨까요?
이렇게 할 경우 dto 하나의 변화가 존재할 때 트래킹의 비용이 증가할 것 같습니다.
StoreDetails의 생성부분을 정적 팩토리 메서드로 만들고, 해당 메서드를 활용하는게 더 나을 것 같습니다.
eom-tae-in
approved these changes
Aug 13, 2024
Comment on lines
41
to
44
| public Object resolveArgument(final MethodParameter parameter, | ||
| final ModelAndViewContainer mavContainer, | ||
| final NativeWebRequest webRequest, | ||
| final WebDataBinderFactory binderFactory) throws Exception { |
There was a problem hiding this comment.
통일성 있게 파라미터가 3개 이상인 경우엔 개행을 추가하고 작성하면 좋을 것 같습니다
| return popups.getId(); | ||
| } | ||
|
|
||
| public void patchById(final Long memberId, final Long popupsId, final PopupsUpdateRequest request) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
추후 개발을 위한 팝업스토어의 간단한 기능 구현 및 커스텀 태그를 구현했습니다.
커스텀 태그를 간접참조 방식으로 만든 이유는 추후에 다른 태그로도 활용할 수 있고 Popups와는 다른 기능적인 측면이 들어가기 때문에 생명주기가 다르다고 판단했고, 확장 가능성이 있기 때문에 기존에 @onetomany 단방향참조에서 간접참조 방식으로 변경했습니다.
추가적으로 @AuthMembers 라는 새로운 어노테이션을 만들었는데, 권한별로 접근 제어를 할 수 있습니다. 개발하실 때 참고해주세요!
🙋🏻 More
close #12