Updated Liquid on status-page

[akdarrah]

When I was testing this theme, I noticed a few problems. So, I tried to get them fixed in this PR! 💪

• I changed apologies and apology to be notices and notice
• I removed formatting from datetime columns. I was getting "Liquid internal error" and having a hard time figuring that out... I even tried copying the formatting from https://github.com/sorry-app/theme-big-green/blob/master/src/status-page.liquid, but no luck. 🤔
• I removed copyright date for the same formatting reason
• I may have fixed a for loop that had an else statement. I'm not sure if that did anything or not, but it works now haha 😁

Not perfect... but better! Feel free to close this PR if I did something wrong here. 😊

[SirRawlins]

Awesome Adam! 💪 This theme hasn't been touched in ages so was well overdue a few fixes, nice work. I'll take a closer look at the PR next week but all looks good to me. Regards to the else statement on the for loop, I think that might get executed if the collection is empty.

…

On Thu, 21 Nov 2019, 17:22 Adam Darrah, ***@***.***> wrote: When I was testing this theme, I noticed a few problems. So, I tried to get them fixed in this PR! 💪 - I changed apologies and apology to be notices and notice - I removed formatting from datetime columns. I was getting "Liquid internal error" and having a hard time figuring that out... I even tried copying the formatting from https://github.com/sorry-app/theme-big-green/blob/master/src/status-page.liquid, but no luck. 🤔 - I removed copyright date for the same formatting reason - I may have fixed a for loop that had an else statement. I'm not sure if that did anything or not, but it works now haha 😁 [image: Dropkiq_Status_Page] <https://user-images.githubusercontent.com/69064/69360985-89b22e80-0c59-11ea-871a-b969aefda115.png> Not perfect... but better! Feel free to close this PR if I did something wrong here. 😊 ------------------------------ You can view, comment on, or merge this pull request online at: #1 Commit Summary - Change apologies to notices - Check if there are notices with an if - Fixed the scopes for the liquid arrays - Removed formatting from times for now - Updated built theme.zip File Changes - *M* dist/theme.zip <https://github.com/sorry-app/theme-example-narrow-jumbotron/pull/1/files#diff-0> (0) - *M* src/status-page.liquid <https://github.com/sorry-app/theme-example-narrow-jumbotron/pull/1/files#diff-1> (61) Patch Links: - https://github.com/sorry-app/theme-example-narrow-jumbotron/pull/1.patch - https://github.com/sorry-app/theme-example-narrow-jumbotron/pull/1.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAFWEK2DKLQQ72EUA4TI6B3QU27W5A5CNFSM4JQFUYX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3FLDWQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFWEK5LRYOTGB4WTIHNAKTQU27W5ANCNFSM4JQFUYXQ> .