This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
add control password creating new member #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreaubbiali Please add the description also in the git commit description not only in the PR description (so your PR will already have a description). Looking at the code I'll also rephrase this to just "disable submit button when the two passwords don't match also when creating a new member" |
sgotti
reviewed
Nov 10, 2018
web/src/app/containers/EditMember.js
Outdated
| @@ -375,6 +375,10 @@ class EditMember extends React.Component { | |||
| if (curMember.password !== curMember.repeatPassword) disabled = true | |||
| } | |||
|
|
|||
| if (type === 'new') { | |||
There was a problem hiding this comment.
Just "or" with the above statement since the code is the same
Disable submit button when the two passwords don't match also when creating a new member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to create a new member, when you have to put the password there is a control that make sure it isn't too short but when you write in the box "repeat password" there isn't the control if the two password are the same. this commit add it.