This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Display full name #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
reviewed
Nov 7, 2018
There was a problem hiding this comment.
@andreaubbiali Thanks for the PR. Can you provide the rationale behind this change and add it to the commit description?
The reason why the username was displayed is that the username is unique while the full name is not and can lead to confusions if some users have the same name. I think we should avoid such confusion finding a better way to show also the full name (other tools usually shows the username while the real name is show when hovering over them or at the right of the username).
web/src/app/containers/Circle.js
Outdated
| @@ -204,7 +204,7 @@ class Circle extends React.Component { | |||
| <Avatar uid={d.member.uid} size={50} floated='right' inline spaced shape='rounded' /> | |||
| <Card.Header> | |||
| <Link to={Util.memberUrl(d.member.uid, timeLine)}> | |||
| {d.member.userName} | |||
| AAA {d.member.fullName} | |||
When mouse is over an username, display a popup with the user full name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display full name