bot: keep track of trigger processing threads #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
This is interesting. As long as it won't lead to any appreciable performance decrease, I see no reason not to keep track of stuff for testing and debugging purposes.
My guess is that looping through the list of running triggers will be quite fast, so it's not really a concern. That list should never get anywhere near a large enough size to cause lock contention.
dgw
requested changes
Nov 14, 2019
Exirel
force-pushed
the
dispatch-thread-join
branch
from
3311f73
to
de806d6
Compare
|
I rebased to fix the conflict, but I'll wait until #1728 is merged before fixing the remaining issues. |
Exirel
force-pushed
the
dispatch-thread-join
branch
2 times, most recently
from
157c5e5
to
73c6312
Compare
Exirel
commented
Nov 20, 2019
dgw
requested changes
Nov 21, 2019
|
All fixed (again). Waiting for a go to squash. |
Co-Authored-By: dgw <[email protected]>
Exirel
force-pushed
the
dispatch-thread-join
branch
from
aeed057
to
4396dcf
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1728 to avoid future merge conflict.
My initial idea was to join trigger processing threads directly in the
dispatchmethod. For several reasons (including the echo-message polyfill), that's not doable.Instead, since all I want is a way to know, access, and join processing threads in automated tests, I make sure the bot keeps track of its threads. This way, I'll be able to run a dispatch, going through all the bot's internals and machineries, and then wait for the end result in my tests.
It was a bit convoluted, but in the end I think it turned out great!
Quick note about memory consumption: this information generate a very low overhead, since running threads are kept in memory anyway by Python. All that is stored is a reference to the thread object, and every time dispatch is called, the list is flushed out of obsolete running threads.