traverse the methodList's copy

soot-oss · Jan 20, 2024 · 7c86a50 · 7c86a50
1 parent 4056d91
commit 7c86a50
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/main/java/soot/SootClass.java b/src/main/java/soot/SootClass.java
@@ -1304,14 +1304,12 @@ public boolean isOpenedByModule() {
    */
   public Collection<SootMethod> getMethodsByNameAndParamCount(String name, int paramCount) {
     List<SootMethod> result = null;
-    synchronized(this) {
-      for (SootMethod m : getMethods()) {
-        if (m.getParameterCount() == paramCount && m.getName().equals(name)) {
-          if (result == null) {
-            result = new ArrayList<>();
-          }
-          result.add(m);
+    for (SootMethod m : new ArrayList<>(getMethods())) {
+      if (m.getParameterCount() == paramCount && m.getName().equals(name)) {
+        if (result == null) {
+          result = new ArrayList<>();
         }
+        result.add(m);
       }
     }