iOS-only: Add input gain / "In Level" slider #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulreimer
force-pushed
the
ios-add-input-gain-slider
branch
from
b1754b6
to
c35879b
Compare
|
Note: the translation strings for "In Level" were already available, so I used that. There seemed to be some old code that referred to it, but was currently unused / unimplemented in the UI (AFAICT). But technically this is a gain and not a level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For audio interfaces which support it on iOS, adds a single interface-wide slider "In Level" (i.e. applies to all input channels) to the Input Mixer.
This allows reducing the audio gain -- potentially at the hardware level, if that is how the audio interface implements it -- which can avoid clipping if a hot signal is present.
Fulfills #216