-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] feat: more precise qbinary handling in tract core with unaligned entry #1333
Merged
kali
merged 40 commits into
sonos:main
from
JulienBalianSonos:fix/elmwise-mul-quant-algined-zp-scale
Mar 5, 2024
Merged
[RFC] feat: more precise qbinary handling in tract core with unaligned entry #1333
kali
merged 40 commits into
sonos:main
from
JulienBalianSonos:fix/elmwise-mul-quant-algined-zp-scale
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& output qparams)
…ized inputs such as relu max(a_qu8, 0.0)
…perations (usefull for quantized tensors)
JulienBalianSonos
force-pushed
the
fix/elmwise-mul-quant-algined-zp-scale
branch
from
February 21, 2024 15:10
e02b862
to
2929ae7
Compare
JulienBalianSonos
changed the title
[WIP] feat: more precise qmul handling in tract core with unaligned entry
[RFC] feat: more precise qmul handling in tract core with unaligned entry
Feb 29, 2024
JulienBalianSonos
changed the title
[RFC] feat: more precise qmul handling in tract core with unaligned entry
[RFC] feat: more precise qbinary handling in tract core with unaligned entry
Feb 29, 2024
kali
reviewed
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ways binary ops are done for math with quantized tensors, by allowing unaligned qparams in input/output tensors.
This change allows increasing precision of quantization and reduce casting/alignment cost, but we now need to handle the qparams of output tensor as function input.
We need to handle all ops implied by
bin_to_super_type macro
already supporting QU8, that may use unaligned qparams quantization.in next cases we directly apply dequant to f32 and requant to targeted qtype for now
we propose to leave aside from this PR: rem, and all "bool" or "bit" operations