Generalize float precision conversion #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emricksinisonos
force-pushed
the
task/generalize-float-precision-conversion
branch
from
f2f68e6 to
f3a434d
Compare
|
We should keep --half-floats as an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conversion from f32 to f16 was already supported, this PR adds the support of f16 to f32 conversion and adds a bit of genericity in the implementation of the converter.
It also breaks high level tract API by replacing the
half()API by:f32_to_f16(): equivalent tohalf(), f32 -> f16 conversionf16_to_f32(): f16 -> f32 conversion