[tests] mark suppress-fib-pending VS test as expected to fail #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
changed the title
|
I don't think we need to revert swss changes. |
|
@prsunny In theory yes, we could keep it. However, please note, as part of this PR I revert a VS test that will not work without FRR config. Reverting just a VS test means I remove the coverage for suppress FIB code. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
may be we can mark the test skipped for now and create an issue to track. |
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
force-pushed
the
revert-suppress-fib
branch
from
4607220
to
b2e4c41
Compare
stepanblyschak
changed the title
|
@prsunny Update PR to just mark the test as x(pected)fail. It was already marked that way to solve a cyclic dependency between sonic-buildimage and sonic-swss changes at that time and forgotten to be removed, now, I just updated the reason message. |
prsunny
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Revert suppress FIB pending feature
Why I did it
Some unresolved FRR issues in current version
How I verified it
Build and run
Details if related