Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sai call to isolate/unisolate a fabric port #3141

Merged
merged 17 commits into from
May 30, 2024

Conversation

jfeng-arista
Copy link
Contributor

Add sai call for isolate/unisolate the fabric links.

Please merge this up after #3132

What I did

Why I did it

How I verified it

Details if related

@jfeng-arista
Copy link
Contributor Author

@rlhui rlhui added the P0 label May 15, 2024
}
else
{
SWSS_LOG_NOTICE( "JFJF same isolation status for %d", lane);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fix this logs message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fix this logs message?

good catch. fixed. thank you !

@vmittal-msft vmittal-msft self-requested a review May 17, 2024 20:36
@jfeng-arista
Copy link
Contributor Author

tests failed with some " 'Invalid response from docker daemon: key "ApiVersion"' ' is missing.' . Not related to this chagne, will restart the tests pipeline

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2).
<class 'AssertionError'>
LAG ID allocator table full error is not returned
assert '0' == '1'

not related to this chagne

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2).
<class 'AssertionError'>
LAG ID allocator table full error is not returned
assert '0' == '1'

not related to this chagne

@prsunny
Copy link
Collaborator

prsunny commented May 22, 2024

test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2). <class 'AssertionError'> LAG ID allocator table full error is not returned assert '0' == '1'

not related to this chagne

@jfeng-arista , looking into it

@jfeng-arista
Copy link
Contributor Author

test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2). <class 'AssertionError'> LAG ID allocator table full error is not returned assert '0' == '1'
not related to this chagne

@jfeng-arista , looking into it

thank you ! this failure seems affecting almost all PRs in swss .

@arlakshm
Copy link
Contributor

@prsunny can you help merge this PR

@prsunny
Copy link
Collaborator

prsunny commented May 28, 2024

@prsunny can you help merge this PR

@arlakshm , please check description. this is dependent on another PR. Or do you think this can go independently?

@arlakshm
Copy link
Contributor

@prsunny can you help merge this PR

@arlakshm , please check description. this is dependent on another PR. Or do you think this can go independently?
Thanks @prsunny. I missed the dependency. @jfeng-arista, is this PR dependent on #3132 ? or we can merge this first?

@jfeng-arista
Copy link
Contributor Author

@prsunny can you help merge this PR

@arlakshm , please check description. this is dependent on another PR. Or do you think this can go independently?
Thanks @prsunny. I missed the dependency. @jfeng-arista, is this PR dependent on #3132 ? or we can merge this first?

we can, just that it will not be protected under than toggle.

@jfeng-arista
Copy link
Contributor Author

the failure not related to this change, it is synced down .

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test failures are from upstream, not related to this change.

@prsunny prsunny merged commit f737663 into sonic-net:master May 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants