-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sai call to isolate/unisolate a fabric port #3141
Add sai call to isolate/unisolate a fabric port #3141
Conversation
orchagent/fabricportsorch.cpp
Outdated
} | ||
else | ||
{ | ||
SWSS_LOG_NOTICE( "JFJF same isolation status for %d", lane); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix this logs message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix this logs message?
good catch. fixed. thank you !
tests failed with some " 'Invalid response from docker daemon: key "ApiVersion"' ' is missing.' . Not related to this chagne, will restart the tests pipeline |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2). not related to this chagne |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2). not related to this chagne |
@jfeng-arista , looking into it |
thank you ! this failure seems affecting almost all PRs in swss . |
@prsunny can you help merge this PR |
|
we can, just that it will not be protected under than toggle. |
the failure not related to this change, it is synced down . |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
/Azp run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
test failures are from upstream, not related to this change. |
Add sai call for isolate/unisolate the fabric links.
Please merge this up after #3132
What I did
Why I did it
How I verified it
Details if related