[System ready] Report ready state to Sysmonitor daemon #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Apr 30, 2024
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
970b334
to
44dc7c8
Compare
|
@fastiuk please refer to the comment provided. also please update the PR description of what are you are trying to fix and the scope. if this is a bug to whihc branches it should go? |
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
44dc7c8
to
0107ebe
Compare
fastiuk
commented
May 16, 2024
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
0107ebe
to
455d78c
Compare
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
455d78c
to
91dd091
Compare
|
@prsunny any more comments? |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Nov 14, 2024
| /* | ||
| * Notify "System ready" feature that we are ok. | ||
| */ | ||
| FieldValueTuple app_state("up_status", "true"); |
There was a problem hiding this comment.
There should be some code to set it "false"?
- when orchagent starts
- when orchagent exited gracefully
- when orchagent receive a signal and exited
- etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends-on: sonic-net/sonic-buildimage#18817
What I did
This change implements swss's ability to report it's readines to sysmonitor
Why I did it
The motivation is to report
PortInitDoneto sysmonitor and not just the startup of swssHow I verified it
sysmonitorDetails if related