Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema.h Changes to support PAC functionality. #871

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Schema.h Changes to support PAC functionality. #871

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f5058f
PAC changes for community
vijaya-ops Apr 4, 2024
3920132
Fixed compilaton issues
vijaya-ops Sep 25, 2024
9b2db89
Merge branch 'sonic-net:master' into community_changes_pac
vijaya-ops Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions common/schema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ namespace swss {
#define APP_DASH_PA_VALIDATION_TABLE_NAME "DASH_PA_VALIDATION_TABLE"
#define APP_DASH_ROUTING_APPLIANCE_TABLE_NAME "DASH_ROUTING_APPLIANCE_TABLE"

#define APP_PAC_PORT_TABLE_NAME "PAC_PORT_TABLE"

/***** TO BE REMOVED *****/

#define APP_TC_TO_QUEUE_MAP_TABLE_NAME "TC_TO_QUEUE_MAP_TABLE"
Expand Down Expand Up @@ -465,6 +467,11 @@ namespace swss {

#define CFG_SUPPRESS_ASIC_SDK_HEALTH_EVENT_NAME "SUPPRESS_ASIC_SDK_HEALTH_EVENT"

#define CFG_PAC_PORT_CONFIG_TABLE "PAC_PORT_CONFIG_TABLE"
#define CFG_PAC_GLOBAL_CONFIG_TABLE "PAC_GLOBAL_CONFIG_TABLE"
#define CFG_PAC_HOSTAPD_GLOBAL_CONFIG_TABLE "HOSTAPD_GLOBAL_CONFIG_TABLE"


/***** STATE DATABASE *****/

#define STATE_SWITCH_CAPABILITY_TABLE_NAME "SWITCH_CAPABILITY"
Expand Down Expand Up @@ -549,6 +556,16 @@ namespace swss {
#define STATE_ACL_TABLE_TABLE_NAME "ACL_TABLE_TABLE"
#define STATE_ACL_RULE_TABLE_NAME "ACL_RULE_TABLE"


/*PAC*/
#define STATE_PAC_GLOBAL_OPER_TABLE "PAC_GLOBAL_OPER_TABLE"
#define STATE_PAC_PORT_OPER_TABLE "PAC_PORT_OPER_TABLE"
#define STATE_PAC_AUTHENTICATED_CLIENT_OPER_TABLE "PAC_AUTHENTICATED_CLIENT_OPER_TABLE"
#define STATE_OPER_VLAN_TABLE_NAME "OPER_VLAN"
#define STATE_OPER_VLAN_MEMBER_TABLE_NAME "OPER_VLAN_MEMBER"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to name it STATE_PAC_OPER_VLAN_TABLE_NAME? to allow for easier identification. same of actual name, something like PAC_OPER_VLAN

Copy link
Author

@vijaya-ops vijaya-ops Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#define STATE_OPER_VLAN_TABLE_NAME "OPER_VLAN"
#define STATE_OPER_VLAN_MEMBER_TABLE_NAME "OPER_VLAN_MEMBER"

The purpose of these two tables is to create VLANs and VLAN memberships dynamically. As of now the PAC is only one, which is creating dynamic VLAN memberships. But in future any other component can use these tables and create the dynamic VLANs and dynamic membership functionality. Hence the PAC key word is not present , for these tables.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your response, good to know

#define STATE_OPER_FDB_TABLE_NAME "OPER_FDB"
#define STATE_OPER_PORT_TABLE_NAME "OPER_PORT"

/***** Counter capability tables for Queue and Port ****/
#define STATE_QUEUE_COUNTER_CAPABILITIES_NAME "QUEUE_COUNTER_CAPABILITIES"
#define STATE_PORT_COUNTER_CAPABILITIES_NAME "PORT_COUNTER_CAPABILITIES"
Expand Down
Loading