Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15524] Fixing the import error and KeyError in snappi_test/multidut executions. #15694

Closed
wants to merge 1 commit into from

Conversation

mssonicbld
Copy link
Collaborator

@sdszhang : This PR attempts to fix the fixture-not-found error and KeyError that you are seeing in the snappi_test multidut runs. Pls let me know if this works for you.

…ns. (sonic-net#15524)

 This PR attempts to fix the fixture-not-found error and KeyError that you are seeing in the snappi_test multidut runs. Pls let me know if this works for you.

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator Author

Original PR: #15524

@mssonicbld
Copy link
Collaborator Author

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:36:25: F811 redefinition of unused 'setup_ports_and_dut' from line 21

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@sdszhang
Copy link
Contributor

@rraghav-cisco the cherry-picked failed with static analysis. can you manually cherry pick the PR into 202405?

tests/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:36:25: F811 redefinition of unused 'setup_ports_and_dut' from line 21

@rraghav-cisco
Copy link
Contributor

This PR attempts to fix the fixture-not-found error and KeyError that you are seeing in the snappi_test multidut runs. Pls let me know if this works for you.

@sdszhang , 202405 PR: #15713

@sdszhang
Copy link
Contributor

close this one as it's being cherry picked manually.

@sdszhang sdszhang closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants