Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour of wait and timeout assignment for T2 devices #14849

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Javier-Tan
Copy link
Contributor

@Javier-Tan Javier-Tan commented Oct 5, 2024

Description of PR

Summary:
Fixes #14840

Changed behaviour of forcing minimum wait and timeout times for reboot on T2 devices to only trigger when safe_reboot == True

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Tests were failing when because of the minimum 900s wait time during reboot for T2 devices, despite explicitly setting wait time.

How did you do it?

Changed behaviour of forcing minimum wait and timeout times for reboot on T2 devices to only trigger when safe_reboot == True

How did you verify/test it?

Tested on T2 testbed to confirm that the effective priority to define wait and timeout variables would now be:
900, 600 for T2 DUT & safe reboot >
values defined in inv >
explicitly defined wait and timeout during function call >
default values in reboot_ctrl_dict

Any platform specific information?

Platform agnostic

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Reboot shouldn't always force min 900s wait on T2 devices
1 participant