Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAC and HOSTAPD YANG files. #16036

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

shdasari
Copy link
Contributor

@shdasari shdasari commented Aug 4, 2023

Why I did it

Added SONiC YANG files for PAC feature (sonic-net/SONiC#1315).

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added PAC_PORT_CONFIG, MAB_PORT_CONFIG, HOSTAPD_GLOBAL_CONFIG tables for PAC configuration.

How to verify it

Compiled sonic_yang_mgmt-1.0-py3-none-any.whl.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

SONiC YANG files for PAC sonic-net/SONiC#1315

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@shdasari shdasari requested a review from qiluo-msft as a code owner August 4, 2023 08:47
@shdasari shdasari marked this pull request as draft August 4, 2023 10:31
@qiluo-msft qiluo-msft requested a review from ganglyu August 4, 2023 18:34
@qiluo-msft qiluo-msft added the YANG YANG model related changes label Aug 4, 2023
@ganglyu
Copy link
Contributor

ganglyu commented Aug 4, 2023

Please check unit test:

------------------- Test 565: HOSTAPD configuration in global configuration table.---------------------
libyang[0]: Invalid JSON data (missing begin-array). (path: /sonic-hostapd:sonic-hostapd/HOSTAPD_GLOBAL_CONFIG/HOSTAPD_GLOBAL_CONFIG_LIST)
INFO:YANG-TEST:Invalid JSON data (missing begin-array).
ERROR:YANG-TEST: Exception >Invalid JSON data (missing begin-array). in not empty< in /sonic/src/sonic-yang-models/tests/yang_model_tests/test_yang_model.py:208
INFO:YANG-TEST:HOSTAPD configuration in global configuration table. Failed

@shdasari
Copy link
Contributor Author

shdasari commented Aug 7, 2023

Please check unit test:

------------------- Test 565: HOSTAPD configuration in global configuration table.--------------------- libyang[0]: Invalid JSON data (missing begin-array). (path: /sonic-hostapd:sonic-hostapd/HOSTAPD_GLOBAL_CONFIG/HOSTAPD_GLOBAL_CONFIG_LIST) INFO:YANG-TEST:Invalid JSON data (missing begin-array). ERROR:YANG-TEST: Exception >Invalid JSON data (missing begin-array). in not empty< in /sonic/src/sonic-yang-models/tests/yang_model_tests/test_yang_model.py:208 INFO:YANG-TEST:HOSTAPD configuration in global configuration table. Failed

Thank you. Corrected the unit test and uploaded changes. Will move to review from draft as soon as build is through successfully.

@shdasari
Copy link
Contributor Author

shdasari commented Aug 8, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chiranjeevi-u
Copy link

Hi Team,
Has the compilation been successful? We are currently working to further enhance the functionality as discussed. Please share any updates you may have.

@ganglyu
Copy link
Contributor

ganglyu commented Nov 17, 2023

Hi Team, Has the compilation been successful? We are currently working to further enhance the functionality as discussed. Please share any updates you may have.

No, please fix unit test.

@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Feb 8, 2024
@zhangyanzhao
Copy link
Collaborator

@shdasari can you please address Gang's comment and fix the unit test? Thanks. Add @adyeung for awareness.

@shdasari
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shdasari shdasari marked this pull request as ready for review April 4, 2024 08:46
@shdasari
Copy link
Contributor Author

shdasari commented Apr 5, 2024

/AzurePipelines run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 16036 in repo sonic-net/sonic-buildimage

}

leaf mab {
type enumeration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

leaf dot1x_system_auth_control {
type enumeration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Container for hostapd global config.";

list HOSTAPD_GLOBAL_CONFIG_LIST {
key "global";
Copy link
Collaborator

@venkatmahalingam venkatmahalingam Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description "Initial revision.";
}

typedef port_mode_enumeration {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to remove _enumeration suffix in all typedefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BRCM Triaged this issue has been triaged YANG YANG model related changes
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

7 participants