Fix GetImageSizeFromUrl for image url without Content-Type #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all images carry a
Content-Typeheader such asimage/. When utilizing object storage solutions like AWS S3, it is essential to define theContent-Typeat the time of upload; failing to do so will result in the adoption of the default content type,binary/octet-stream.At present, the benefit of identifying the
Content-Typelies in conserving bandwidth by filtering out invalid image URLs. Nevertheless, this approach incurs the expense of an additionalHEADrequest for each URL. Considering that the majority of URLs point to valid images, the overhead introduced by these requests outweighs the potential benefits.