Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NxDropdown Managed Key Navigation with aria-activedescendant - RSC-989 #901

Draft
wants to merge 100 commits into
base: RSC-989_add-managed-keynav-and-roles-to-nx-dropdown
Choose a base branch
from
Draft

NxDropdown Managed Key Navigation with aria-activedescendant - RSC-989 #901

wants to merge 100 commits into from

Conversation

entroform
Copy link
Contributor

No description provided.

Rani Patel and others added 30 commits December 19, 2022 15:43
progress on conversion - RSC-1285
c62ced0
begin test conversion for first portion of tests - RSC-1234
7bed3c3
toggle open - RSC-1285
17f2d62
onToggle - RSC-1285
c933d2d
@rjp99 @rpokorny
Update lib/src/components/NxAccordion/stateful/__tests__/NxStatefulAc…
20f58db 
…cordion.test.tsx

Co-authored-by: Ross Pokorny <[email protected]>
Merge branch 'main' into RSC-1285_stateful_accordion_RTL
173fb95
added tests - RSC-1285
c5fb4cf
conflicts - RSC-1285
d4f6d98
Merge branch 'main' into RSC-1285_stateful_accordion_RTL
77e519d
continue work on conversion - RSC-1234
054d1f2
Merge branch 'main' into RSC-1234_NxTransferListHalf_rtl_conversion
10787a8
@rjp99 @rpokorny
Update lib/src/components/NxAccordion/stateful/__tests__/NxStatefulAc…
7ef00d1 
…cordion.test.tsx

Co-authored-by: Ross Pokorny <[email protected]>
@rjp99 @rpokorny
Update lib/src/components/NxAccordion/stateful/__tests__/NxStatefulAc…
2f17d25 
…cordion.test.tsx

Co-authored-by: Ross Pokorny <[email protected]>
@rjp99 @rpokorny
Update lib/src/components/NxAccordion/stateful/__tests__/NxStatefulAc…
8dd6141 
…cordion.test.tsx

Co-authored-by: Ross Pokorny <[email protected]>
@rjp99 @rpokorny
Update lib/src/components/NxAccordion/stateful/__tests__/NxStatefulAc…
9231c4d 
…cordion.test.tsx

Co-authored-by: Ross Pokorny <[email protected]>
Merge branch 'main' into RSC-1285_stateful_accordion_RTL
4ec36d9
Merge branch 'RSC-1285_stateful_accordion_RTL' of https://github.com/…
0967312 
…sonatype/sonatype-react-shared-components into RSC-1285_stateful_accordion_RTL
remove class - RSC-1285
6078c7c
continue work on conversion - RSC-1234
e3278d9
change test order - RSC-1285
7fe3a94
cleanup tests- RSC-1234
5fad745
fix range.getBoundingClientRect is not a function - RSC-1234
2e2a677
add tooltip tests for reordering btns - RSC-1234
6d1dffc
@EmilyBermudez88 @rpokorny
update test name - RSC-1285
56703c6 
Co-authored-by: Ross Pokorny <[email protected]>
add assertions about open state for onClick events - RSC-1285
7188b0a
add reminder to improve testing - RSC-1234
76ab1ca
move Range.prototype.getBoundingClientRect() into setupTests.ts - RSC…
26ae3c2 
…-1234
@EmilyBermudez88 @rpokorny
update test name - RSC-1234
f9bc1df 
Co-authored-by: Ross Pokorny <[email protected]>
Merge branch 'main' into RSC-1234_NxTransferListHalf_rtl_conversion
09649e0
@rpokorny
Use fake timers everywhere - RSC-1336
bb0d6b5
Serhii-Bondarchuk and others added 25 commits January 13, 2023 11:24
@Serhii-Bondarchuk
changed import for userEvent
611ef5f
@Serhii-Bondarchuk
changed from describe() to it()
8c08d91
@Serhii-Bondarchuk
changed test to check alert role
2f1572f
@Serhii-Bondarchuk
added more cases to test
c89e56f
@Serhii-Bondarchuk
updated version
d80043b
@rpokorny
Stabilize visual test snapshots - RSC-1341
ec2260a
@rpokorny
Use image from main for actually-unchanged visual test - RSC-1341
cc1f10f
@EmilyBermudez88
Merge pull request #879 from sonatype/RSC-1285_stateful_accordion_RTL
50f3130 
NxStateful Accordion RTL Conversion - RSC-1285
Merge branch 'main' into RSC-1234_NxTransferListHalf_rtl_conversion
d730b34
version bump - RSC-1234
65925b1
@rpokorny
Merge branch 'main' into RSC-1342_tree_scroll_on_click
9a30725
@rpokorny
Merge branch 'main' into RSC-1341_button_focus_and_active_states
a1e0434
@rpokorny
Version bump - RSC-1341
d01c3df
@rpokorny
Version bump - RSC-1342
eaea770
@EmilyBermudez88
Merge pull request #880 from sonatype/RSC-1234_NxTransferListHalf_rtl…
61dce5c 
…_conversion

RSC-1234 - NxTransferListHalf RTL Conversion
@rpokorny
Merge branch 'main' into RSC-1341_button_focus_and_active_states
0849456
@rpokorny
Version bump - RSC-1341
fc1eb92
@rpokorny
Merge branch 'main' into RSC-1342_tree_scroll_on_click
e789639
@rpokorny
Version bump - RSC-1342
9b50b24
@rpokorny
Merge branches 'RSC-1341_button_focus_and_active_states' and 'RSC-134…
2f12ac5 
…2_tree_scroll_on_click'

Avoid Focus States Leaking into Active States on NxButton - RSC-1341 #897
Avoid Scroll on Tree Label Mousedown - RSC-1342 #896
@Serhii-Bondarchuk
Merge branch 'main' into RSC-1226_Load_Wrapper-convert_tests_to_RTL
09b03db
@Serhii-Bondarchuk
added more test casess
ccc1ccf
@Serhii-Bondarchuk
update version
74856cc
@Serhii-Bondarchuk
Merge pull request #894 from sonatype/RSC-1226_Load_Wrapper-convert_t…
56dcc39 
…ests_to_RTL

RSC-1226 Load Wrapper - convert tests to RTL
Testing activedescendant. RSC-989
d753e9e
@entroform entroform changed the title RSC-989: NxDropdown Managed Key Navigation with aria-activedescendant NxDropdown Managed Key Navigation with aria-activedescendant: RSC-989 Jan 16, 2023
@entroform entroform marked this pull request as draft January 16, 2023 15:47
@entroform entroform changed the title NxDropdown Managed Key Navigation with aria-activedescendant: RSC-989 NxDropdown Managed Key Navigation with aria-activedescendant - RSC-989 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@entroform @rjp99 @EmilyBermudez88 @rpokorny @Serhii-Bondarchuk