Update color picker hover colors - RSC-1547 #1177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, now that the hover color is different from the regular color, we need a separate visual test for each hover color. |
rpokorny
reviewed
Nov 10, 2023
| * the terms of the Eclipse Public License 2.0 which accompanies this | ||
| * distribution and is available at https://www.eclipse.org/legal/epl-2.0/. | ||
| */ | ||
|
|
There was a problem hiding this comment.
I see that this follows the same pattern as the tag variables and that's good. However, I'm now realizing that that pattern violations one of the rules of our folder organization. See the following from the readme in this directory:
The files in this directory must not emit anything on their own when compiled, as anything that they
do emit would be duplicated every time one of the files is imported
We should create a separate ticket to clean this up; but continue as-is for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonatype.atlassian.net/jira/software/c/projects/RSC/boards/207?selectedIssue=RSC-1547