Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to include librarian-puppet support #5

Open
wants to merge 1 commit into
base: ModulesEndpoint
Choose a base branch
from
Open

Update README to include librarian-puppet support #5

wants to merge 1 commit into from

Conversation

AtilaSuleyman
Copy link

No description provided.

@sonatypecla
Copy link

sonatypecla bot commented Dec 6, 2018

Thanks for the contribution! Before we can merge this, we need @AtilaSuleyman to sign the Sonatype Contributor License Agreement.

@sonatypecla
Copy link

sonatypecla bot commented Dec 6, 2018

Thanks for the contribution! Before we can merge this, we need @AtilaSuleyman to sign the Sonatype Contributor License Agreement.

DarthHater
DarthHater approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@DarthHater DarthHater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! I would suggest adding some instructions to https://github.com/sonatype-nexus-community/nexus-repository-puppet/blob/master/docs/PUPPET_USER_DOCUMENTATION.md#configuring-puppet with some specific instructions for using librarian-puppet. That would likely be helpful for others. What do you think?

@AtilaSuleyman
Copy link
Author

@DarthHater Yes thats a good idea, I will do that soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarthHater DarthHater DarthHater approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtilaSuleyman @DarthHater