Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to extract values from enum types at AbstractPropertySourceIterator::getValue() #648

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

phansys
Copy link
Member

@phansys phansys commented Oct 21, 2023

Subject

Allow to extract values from enum types at AbstractPropertySourceIterator::getValue()

I am targeting this branch, because this change respects BC.

Changelog

### Added
- Support for enum types in exported values.

@phansys phansys force-pushed the source_enum branch 3 times, most recently from 6e6cf3f to 79fe86e Compare October 21, 2023 23:54
@phansys phansys requested a review from a team October 21, 2023 23:55
@phansys phansys marked this pull request as ready for review October 21, 2023 23:55
VincentLanglet
VincentLanglet previously approved these changes Oct 22, 2023
@phansys
Copy link
Member Author

phansys commented Oct 22, 2023

Thanks for you review @VincentLanglet.
I just made a new push adding an option to allow users to control the behavior for backed enums, in order to choose the enum's name even when the enum is backed.

@phansys phansys requested a review from a team October 22, 2023 15:52
@phansys phansys added the minor label Oct 22, 2023
VincentLanglet
VincentLanglet previously approved these changes Oct 22, 2023
@phansys phansys merged commit 3b48cec into sonata-project:3.x Oct 23, 2023
33 checks passed
@phansys phansys deleted the source_enum branch October 23, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants