-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install xmllint manually #362
Install xmllint manually #362
Conversation
Please also use |
I am not an expert on those commands, can you show me how to replace find with xargs? |
Here is an example: https://stackoverflow.com/questions/896808/find-exec-cmd-vs-xargs#897043 |
-not -path './vendor/*' -not -path './Resources/public/vendor/*' -type f \ | ||
-exec xmllint --encode UTF-8 --output '{}' --format '{}' \; | ||
-not -path './vendor/*' -not -path './Resources/public/vendor/*' \ | ||
| xargs -I'{}' xmllint --encode UTF-8 --output '{}' --format '{}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on my environment
project/.travis/install_lint.sh
Outdated
@@ -9,3 +9,4 @@ chmod u+x "${HOME}/bin/php-cs-fixer" | |||
composer global require sllh/composer-lint:@stable --prefer-dist --no-interaction | |||
|
|||
gem install yaml-lint | |||
sudo apt-get install -y libxml2-utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it's working? Sudo is not activated on Travis AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check on adminbundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work indeed. Do I need to enable sudo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not. It decrease performance a lot.
No another way to get this binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying other way to install it
40a218d
to
210ff41
Compare
addons: | ||
apt: | ||
packages: | ||
- libxml2-utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the other way I found @soullivaneuh
With this it works on admin-bundle: https://travis-ci.org/sonata-project/SonataAdminBundle/jobs/312312396 |
Closes #359
Xmllint is not installed by default since we use trusty: xwp/wp-dev-lib#247
Proof that it does not work: just look at this lint build, there are a lot of lines of xmllint not found https://travis-ci.org/sonata-project/SonataAdminBundle/jobs/311420072