Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevKit updates for 5.x branch #1670

Merged
merged 2 commits into from
Jan 22, 2024
Merged

DevKit updates for 5.x branch #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2fe127
DevKit updates
SonataCI Jan 22, 2024
1ac383d
Solve issues
VincentLanglet Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"phpunit/phpunit": "^9.5",
"psalm/plugin-phpunit": "^0.18",
"psalm/plugin-symfony": "^5.0",
"rector/rector": "^0.18",
"rector/rector": "^0.19",
"sonata-project/admin-bundle": "^4.20",
"sonata-project/block-bundle": "^4.11 || ^5.0",
"sonata-project/doctrine-orm-admin-bundle": "^4.0",
Expand Down
1 change: 1 addition & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ parameters:
featureToggles:
skipCheckGenericClasses:
- Symfony\Component\Form\AbstractType
- Symfony\Component\Form\FormBuilderInterface
- Symfony\Component\Form\FormInterface
- Symfony\Component\Form\FormTypeExtensionInterface
- Symfony\Component\Form\FormTypeInterface
2 changes: 1 addition & 1 deletion src/Action/LoginAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ public function __invoke(Request $request): Response
/**
* TODO: Use instanceof FlashBagAwareSessionInterface when dropping Symfony 5 support.
*
* @phpstan-ignore-next-line
* @psalm-suppress UndefinedInterfaceMethod
* @phpstan-ignore-next-line
*/
$request->getSession()->getFlashBag()->add(
'sonata_user_error',
Expand Down
2 changes: 1 addition & 1 deletion src/Action/ResetAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ public function __invoke(Request $request, string $token): Response
/**
* TODO: Use instanceof FlashBagAwareSessionInterface when dropping Symfony 5 support.
*
* @phpstan-ignore-next-line
* @psalm-suppress UndefinedInterfaceMethod
* @phpstan-ignore-next-line
*/
$request->getSession()->getFlashBag()->add(
'success',
Expand Down
Loading