Catch possible null error when retriving site

sonata-project · May 1, 2020 · f70c2b2 · f70c2b2
1 parent edab41e
commit f70c2b2
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/src/Block/ChildrenPagesBlockService.php b/src/Block/ChildrenPagesBlockService.php
@@ -67,10 +67,13 @@ public function execute(BlockContextInterface $blockContext, ?Response $response
         } elseif ($settings['pageId']) {
             $page = $settings['pageId'];
         } else {
+            $page = false;
             try {
-                $page = $cmsManager->getPage($this->siteSelector->retrieve(), '/');
+                $site = $this->siteSelector->retrieve();
+                if (null !== $site) {
+                    $page = $cmsManager->getPage($site, '/');
+                }
             } catch (PageNotFoundException $e) {
-                $page = false;
             }
         }
 

diff --git a/src/Route/CmsPageRouter.php b/src/Route/CmsPageRouter.php
@@ -302,6 +302,11 @@ protected function getRelativePath($basePath, $targetPath)
     protected function getPageByPageAlias($alias)
     {
         $site = $this->siteSelector->retrieve();
+
+        if (null === $site) {
+            return null;
+        }
+
         $page = $this->cmsSelector->retrieve()->getPageByPageAlias($site, $alias);
 
         return $page;

diff --git a/src/Site/BaseSiteSelector.php b/src/Site/BaseSiteSelector.php
@@ -44,7 +44,7 @@ abstract class BaseSiteSelector implements SiteSelectorInterface
     protected $seoPage;
 
     /**
-     * @var SiteInterface
+     * @var SiteInterface|null
      */
     protected $site;
 

diff --git a/src/Site/SiteSelectorInterface.php b/src/Site/SiteSelectorInterface.php
@@ -25,7 +25,7 @@
 interface SiteSelectorInterface
 {
     /**
-     * @return SiteInterface
+     * @return SiteInterface|null
      */
     public function retrieve();
 

diff --git a/src/Twig/Extension/PageExtension.php b/src/Twig/Extension/PageExtension.php
@@ -147,10 +147,14 @@ public function breadcrumb(?PageInterface $page = null, array $options = [])
             $breadcrumbs = $page->getParents();
 
             if ($options['force_view_home_page'] && (!isset($breadcrumbs[0]) || 'homepage' !== $breadcrumbs[0]->getRouteName())) {
+                $site = $this->siteSelector->retrieve();
+
+                $homePage = false;
                 try {
-                    $homePage = $this->cmsManagerSelector->retrieve()->getPageByRouteName($this->siteSelector->retrieve(), 'homepage');
+                    if (null !== $site) {
+                        $homePage = $this->cmsManagerSelector->retrieve()->getPageByRouteName($site, 'homepage');
+                    }
                 } catch (PageNotFoundException $e) {
-                    $homePage = false;
                 }
 
                 if ($homePage) {
@@ -201,7 +205,7 @@ public function renderContainer($name, $page = null, array $options = [])
         try {
             if (null === $page) {
                 $targetPage = $cms->getCurrentPage();
-            } elseif (!$page instanceof PageInterface && \is_string($page)) {
+            } elseif (null !== $site && !$page instanceof PageInterface && \is_string($page)) {
                 $targetPage = $cms->getInternalRoute($site, $page);
             } elseif ($page instanceof PageInterface) {
                 $targetPage = $page;