DevKit updates for 3.x branch (#616)

Co-authored-by: Vincent Langlet <[email protected]>
sonata-project · Jul 15, 2024 · 686c619 · 686c619
1 parent e6b5886
commit 686c619
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/rector.php b/rector.php
@@ -19,7 +19,6 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Php70\Rector\FunctionLike\ExceptionHandlerTypehintRector;
-use Rector\PHPUnit\CodeQuality\Rector\Class_\AddSeeTestAnnotationRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\LevelSetList;
@@ -40,7 +39,6 @@
     $rectorConfig->importShortClasses(false);
     $rectorConfig->skip([
         ExceptionHandlerTypehintRector::class,
-        AddSeeTestAnnotationRector::class,
         PreferPHPUnitThisCallRector::class,
     ]);
 };
diff --git a/src/Helper/BaseHelper.php b/src/Helper/BaseHelper.php
@@ -85,19 +85,19 @@ public static function getICUDataVersion(): string
             foreach ($info as $line) {
                 $results = [];
 
-                if (preg_match('/(ICU Data version|ICU version) => (.*)/', $line, $results) > 0) {
+                if (1 === preg_match('/(ICU Data version|ICU version) => (.*)/', $line, $results)) {
                     return $results[2];
                 }
             }
         } else {
             foreach ($info as $line) {
                 $results = [];
 
-                if (preg_match('/(ICU Data version).*/', $line, $results) > 0) {
+                if (1 === preg_match('/(ICU Data version).*/', $line, $results)) {
                     return trim(strtolower(strip_tags($results[0])), 'ICU Data version');
                 }
 
-                if (preg_match('/(ICU version).*/', $line, $results) > 0) {
+                if (1 === preg_match('/(ICU version).*/', $line, $results)) {
                     return trim(strtolower(strip_tags($results[0])), 'icu version');
                 }
             }