Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use block-bundle ^5.0 #1776

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Use block-bundle ^5.0 #1776

merged 1 commit into from
Nov 19, 2023

Conversation

dmaicher
Copy link
Contributor

No description provided.

@dmaicher
Copy link
Contributor Author

@franmomu does #1773 fix those CI test fails? 🤔

@VincentLanglet
Copy link
Member

I relaunched the Ci from #1773, if it pass, I'll merge it.

@dmaicher dmaicher force-pushed the block-bundle-5 branch 2 times, most recently from b22cd55 to 4203a0b Compare November 19, 2023 18:37
@dmaicher dmaicher marked this pull request as ready for review November 19, 2023 18:42
@dmaicher dmaicher requested a review from a team November 19, 2023 18:42
@VincentLanglet VincentLanglet merged commit b78bf53 into sonata-project:4.x Nov 19, 2023
25 checks passed
@dmaicher dmaicher mentioned this pull request Nov 19, 2023
Merged
@franmomu
Copy link
Member

@franmomu does #1773 fix those CI test fails? 🤔

that's what the idea, but I wasn't sure, glad that it worked at least temporarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
pedantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmaicher @VincentLanglet @franmomu